[Non backward compatible] Making promises more compliant with standards#13
Merged
divdavem merged 1 commit intoariatemplates:masterfrom Jun 11, 2014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes promises more compliant with standards, cf MDN:
thenandthenSync. It adds thespreadandspreadSyncmethods to pass the array fulfillment value to the handler as multiple arguments. This changes the API ofasyncRequireandrequestin the following way:Old usage:
New usage:
This pull request adds the following new methods (and removes the corresponding old ones):
Promise.resolvePromise.rejectPromise.allPromise.whenPromise.allSettledPromise.whenAllpromiseInstance.catchpromiseInstance.finallypromiseInstance.alwayspromiseInstance.donepromiseInstance.endNote that the
then,catch,finallyandspreadmethods have their equivalentthenSync,catchSync,finallySyncandspreadSyncmethods, which call their handler synchronously if the promise is already either fulfilled or rejected at the time thexSyncmethod is called.