Conversation
tools/ARIAtools/ARIAProduct.py
Outdated
|
|
||
| def __init__(self, filearg, bbox=None, workdir='./', num_threads=1, | ||
| url_version='None', nc_version='None', verbose=False): | ||
| url_version='None', nc_version='1c', verbose=False): |
There was a problem hiding this comment.
nc_version was giving me error so I set it to be the latest initially
|
@mgovorcin this PR looks solid, thanks for the integration of the discussed features and clean-up! I was able to get it working on my end with some minor fixes. I have a few of broader notes: To extract the total tropo by default though (i.e. without the user having to specify it as an argument), I reintroduced the Hence because of this, I made some changes to the way the default layers are managed and extracted. |
| # e.g. [unwrappedPhase, unwrapPhase, unwrap] | ||
| # NOTE is it necessary to have the option for different names | ||
| # as they are hardcoreded, maybe because of different nc version, double-check? | ||
| _find_match = lambda x: re.findall('[A-Z][^A-Z]*', x)[0] \ |
There was a problem hiding this comment.
This could be moved to a separate script that check the nc version, input files, find stored layers in the container and output the layers names for futher processing. Maybe for a next update :D
| if re.search('tropo', x) \ | ||
| else re.findall('[a-z][^A-Z]*', x)[0] | ||
|
|
||
| # Special case - gacos correction files |
There was a problem hiding this comment.
Do not know Sim is it better to move older version of code for correcting unwrapped Phase with total tropo delay from GACOS to separate script:
- ingest GACOS products, and prepare tropoTotal vrt files (in a similar manner like ariaExtract.py)
- use tsSetup.py to prepare tropoTotal stack vrt
- have optional script to treat unwrappedPhase files with GACOS/other model tropoTotal files
There was a problem hiding this comment.
This is simplify both ariaExtract and tsSetup scripts,
There was a problem hiding this comment.
@mgovorcin I understood that the intention was though to no longer directly correct the phase through ARIA-tools. I.e. once I merge these changes, we should work to now push corrections to a separate cube which we then interface with MintPy to use instead to correct the phase on their end.
add function to create troposphereTotal on the fly using gdal PixelFunction
did little clean up, please feel free to reject suggestions