Conversation
Contributor
Author
|
Updated test expectations in GasCosts. |
Marenz
suggested changes
Nov 19, 2019
| EVM_VERSIONS+=" constantinople petersburg istanbul" | ||
| fi | ||
|
|
||
| # And then run the Solidity unit-tests in the matrix combination of optimizer / no optimizer |
Contributor
There was a problem hiding this comment.
Is the comment below this line still correct?
leonardoalt
reviewed
Nov 19, 2019
erak
approved these changes
Nov 19, 2019
| do | ||
| clean | ||
| force_solc_settings "$CONFIG" "$optimize" "petersburg" | ||
| force_solc_settings "$CONFIG" "$optimize" "istanbul" |
Collaborator
There was a problem hiding this comment.
This will probably break some tests, but what could one do 😉
Contributor
Author
There was a problem hiding this comment.
I'm unsure about the changes in the test scripts.
chriseth
reviewed
Nov 20, 2019
test/libsolidity/GasCosts.cpp
Outdated
| if (evmVersion < EVMVersion::istanbul()) | ||
| CHECK_DEPLOY_GAS(151455, 127653, evmVersion); | ||
| else | ||
| CHECK_DEPLOY_GAS(123, 113821, evmVersion); |
Contributor
There was a problem hiding this comment.
The 123 here is just not hit by the tests, right?
Contributor
Author
There was a problem hiding this comment.
Yes, marked them as 0 in a commit.
chriseth
reviewed
Nov 20, 2019
| if (Options::get().optimizeYul) | ||
| CHECK_DEPLOY_GAS(151455, 127653, evmVersion); | ||
| { | ||
| if (evmVersion < EVMVersion::istanbul()) |
Contributor
There was a problem hiding this comment.
It might have been better to directly take the data gas cost change into account and keep the constants.
chriseth
approved these changes
Nov 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7310.
Depends on #7655.