Use std::optional<> rather than boost::optional<>#7551
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
3fecd8a to
2e56c6f
Compare
Collaborator
erak
reviewed
Oct 18, 2019
erak
reviewed
Oct 18, 2019
erak
requested changes
Oct 18, 2019
Collaborator
erak
left a comment
There was a problem hiding this comment.
Left a tiny comment. And we need to figure out, why Emscripten fails.
2e56c6f to
67c6f94
Compare
Contributor
|
Why not target the develop branch? |
67c6f94 to
7021f33
Compare
Contributor
Author
Sure, I could do that BUT I assumed that due to changing 3rd party library code, it may potentially be a little more risky, and using a new major release gives enough head-room. Should I rebase on top of |
Collaborator
|
I'd also feel more confident with targeting 0.6.0, which should us give some more time if there any unforseen issues as well. |
7021f33 to
df729b3
Compare
Contributor
Author
@chriseth rebased on |
chriseth
approved these changes
Oct 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs #7259