Conversation
chriseth
commented
Oct 15, 2019
| } | ||
| // Another special case for `address(this).balance`. Post-Istanbul, we can use the selfbalance | ||
| // opcode. | ||
| // TODO also add optimizer rule `balance(address) -> selfbalance`. |
Contributor
Author
There was a problem hiding this comment.
This needs information about the dialect together with the rules (or applicability function?).
Collaborator
There was a problem hiding this comment.
Shall we create an issue which tracks this?
erak
reviewed
Oct 16, 2019
| bytes expectation({uint8_t(Instruction::SELFBALANCE)}); | ||
| BOOST_CHECK_EQUAL_COLLECTIONS(code.begin(), code.end(), expectation.begin(), expectation.end()); | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
Does it make sense to check that BALANCE together with ADDRESS is used for pre-Istanbul here? Couldn't find a test which does that check.
Collaborator
|
Tests are failing due to a weird Circle glitch(?). We can try to retrigger the tests. |
erak
approved these changes
Oct 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References #7310