fix doc create2#7531
Merged
chriseth merged 1 commit intoargotorg:developfrom Oct 15, 2019
jochem-brouwer:fix-docs-create2
Merged
fix doc create2#7531chriseth merged 1 commit intoargotorg:developfrom jochem-brouwer:fix-docs-create2
chriseth merged 1 commit intoargotorg:developfrom
jochem-brouwer:fix-docs-create2
Conversation
julian-st
approved these changes
Oct 11, 2019
julian-st
left a comment
There was a problem hiding this comment.
looks good to me, 0xff is one byte
chriseth
approved these changes
Oct 15, 2019
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Docs of CREATE2 assembly are incorrect - they note that
0xffis a 8 byte value. I suppose this is a typo where either 8 bit value was meant but I changed it to1 byte.Reference:
https://github.com/ethereum/EIPs/blob/master/EIPS/eip-1014.md
This notes
0xffis a byte, not 8 bytes. (To generate thekeccakhash to figure out the target deployment address).