Allow underscores in hex strings.#7374
Merged
chriseth merged 1 commit intodevelop_060from Sep 9, 2019
Merged
Conversation
chriseth
reviewed
Sep 6, 2019
chriseth
reviewed
Sep 6, 2019
| } | ||
| } | ||
| // ---- | ||
| // ParserError: (52-56): Expected even number of hex-nibbles within double-quotes. |
Contributor
There was a problem hiding this comment.
This error message is misleading - the number of nibbles is even.
Collaborator
Author
There was a problem hiding this comment.
Better now? It wasn't triggered on missing quotes anyways... and that part was actually even wrong, since single quotes are valid as well...
e55b89f to
2373001
Compare
|
Test failing |
Collaborator
Author
That's a lie :-). EDIT: [maybe we should really disable the solhint test to avoid this kind of confusion] |
2373001 to
8e913eb
Compare
8e913eb to
39325b8
Compare
39325b8 to
6f3341a
Compare
chriseth
approved these changes
Sep 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7290