Replace boost::regex library with std::regex#6997
Closed
djuanit0x wants to merge 2 commits intoargotorg:developfrom
Closed
Replace boost::regex library with std::regex#6997djuanit0x wants to merge 2 commits intoargotorg:developfrom
djuanit0x wants to merge 2 commits intoargotorg:developfrom
Conversation
chriseth
reviewed
Jun 25, 2019
Contributor
|
There still seem to be some problems here. Did you try to compile locally? |
Author
|
Nope, I keep getting an error when running |
Contributor
|
It looks like stdc++ does not support regex_replace where the replacement is performed by a lambda function. So you would have to write some glue code. This might be more complicated than I initially though - sorry about that! |
Author
|
No problem:smile:. I am closing this PR, since I have some troubles with the testing. |
Contributor
|
@djuanit0x thanks a lot for trying! |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I address #6971