Mention that constant and payable are deprecated in the ABI spec#4549
Mention that constant and payable are deprecated in the ABI spec#4549
Conversation
| * ``components``: used for tuple types (more below). | ||
|
|
||
| - ``outputs``: an array of objects similar to ``inputs``, can be omitted if function doesn't return anything; | ||
| - ``payable``: ``true`` if function accepts ether, defaults to ``false``; |
There was a problem hiding this comment.
@axic One quick thing here… With lists, you can end the bullet points with whatever you want, but keep them consistent, or follow grammatically. So here the semi-colons might not really be needed. It's a very small thing, so feel free to ignore, and I can polish in the future.
There was a problem hiding this comment.
I kept the original punctuation, not sure why semi-colon was used in the first place.
There was a problem hiding this comment.
@axic No worries, an overall overhaul is due very soon anyway :)
docs/abi-spec.rst
Outdated
| The fields ``constant`` and ``payable`` are deprecated and will be removed in the future. Instead, the ``stateMutability`` field can be used to determine the same properties. | ||
|
|
||
| .. note:: | ||
| Sending non-zero ether to non-payable function will throw. Don't do it. |
There was a problem hiding this comment.
Good idea, will change all occurrences in this file. Before we had revert and "reverting the state", it was usually just "throw" referring to the language statement.
There was a problem hiding this comment.
@axic Did you do this? Or was this more for me to do in the future?
|
@ChrisChinchilla @leonardoalt updated, ok to merge? |
No description provided.