Replace IF..ELSE IF with SWITCH..CASE#4363
Closed
khanrn wants to merge 2 commits intoargotorg:developfrom
Closed
Conversation
erak
requested changes
Jun 29, 2018
Collaborator
erak
left a comment
There was a problem hiding this comment.
Please also change the commit message to something more meaningful.
libevmasm/KnownState.cpp
Outdated
|
|
||
| assertThrow(info.ret <= 1, InvalidDeposit, ""); | ||
| if (info.ret == 1) | ||
| { |
Collaborator
There was a problem hiding this comment.
These are not needed here and can be removed again. In general, we're striving towards a coding style that supports displaying as many lines as possible on one screen.
libevmasm/KnownState.cpp
Outdated
| ); | ||
| } | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
The above comment also applies to the new lines that you've added.
chriseth
previously approved these changes
Jun 29, 2018
ae4dd7d to
20c5d7f
Compare
Removed unnecessary lines Removed unnecessary lines
20c5d7f to
5e0219b
Compare
Contributor
Author
|
Some git issue happened when squashing. A cleaned #4398 PR has been submitted as a replacement of this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think
SWITCH..CASE..DEFAULTis much simpler thanIF..ELSE IF..ELSE. 🙂