Conversation
Contributor
Author
|
Need to fix the build failure. Alternatively we could keep the commit hash in the documentation and keep a comment in |
chriseth
reviewed
Jun 26, 2018
docs/contributing.rst
Outdated
|
|
||
| .. note :: | ||
|
|
||
| While any version of ``cpp-ethereum`` should be usable, this cannot be guaranteed, and it is suggested to use the same version as used by the Solidity continuous integration tests are doing. |
Collaborator
There was a problem hiding this comment.
Should we explicitly mention that certain commit ranges of cpp-ethereum are known to fail due to bugs?
Contributor
Author
There was a problem hiding this comment.
I wouldn't go as far as that, but at least mention the hash we are using, which is supposed to work.
ekpyron
previously requested changes
Jul 12, 2018
docs/contributing.rst
Outdated
|
|
||
| .. note :: | ||
|
|
||
| While any version of ``cpp-ethereum`` should be usable, this cannot be guaranteed, and it is suggested to use the same version as used by the Solidity continuous integration tests are doing. |
Collaborator
There was a problem hiding this comment.
This block needs indentation. Because it's missing the docs build is failing.
31374e1 to
a0bdfc2
Compare
Contributor
Author
Contributor
|
Rebased and corrected grammar. |
chriseth
approved these changes
Jul 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.