Split up NameAndTypeResolution test cases#4178
Conversation
| char const* text = R"( | ||
| contract C { | ||
| function f(uint a) pure public { | ||
| function f(uint) pure public { |
There was a problem hiding this comment.
This test case was duplicated. There is the other one above this called "warn_unused_function_parameter".
| char const* text = R"( | ||
| contract C { | ||
| function f() pure public returns (uint) { | ||
| return 1; |
| char const* text = R"( | ||
| contract C { | ||
| function f() public view returns (uint256 val) { return msg.gas; } | ||
| function f() public view returns (uint256 val) { return gasleft(); } |
There was a problem hiding this comment.
Swapped one test case hence the confusing change.
|
Still need to split up about 8 cases. |
| } | ||
|
|
||
| BOOST_AUTO_TEST_CASE(overflow_caused_by_ether_units) | ||
| BOOST_AUTO_TEST_CASE(no_overflow_with_large_literal) |
There was a problem hiding this comment.
Can you somehow make sure that this an the next test end up next to each other or at least have a similar name or reference each other in a comment?
There was a problem hiding this comment.
I think this is the only exception, the others are grouped. Not sure what is the best name for grouping, perhaps overflow_not_caused_with_large_literal_without_denomination.
chriseth
left a comment
There was a problem hiding this comment.
Please somehow ensure that split test cases reference each other so that the purpose of the test case is clear.
|
Please rebase. |
69098b7 to
14ee42b
Compare
|
Split up some other cases, will squash before merge. I think there are only 3 (albeit monster) current cases left to be split. |
14ee42b to
2d7e090
Compare
|
@chriseth can you review please? |
| text = R"( | ||
| } | ||
|
|
||
| BOOST_AUTO_TEST_CASE(comparison_of_function_types_gt) |
chriseth
left a comment
There was a problem hiding this comment.
Please fix the single lt case together with the rebase and merge.
2d7e090 to
ddc4492
Compare
|
@chriseth updated |
Depends on #4177.
The reason for this is to fix some bugs and prepare the test cases for easy extraction via scripts (it works very well after this).