Conversation
|
Left a couple of tests in |
| @@ -0,0 +1,5 @@ | |||
| contract Foo { | |||
| function f(uint[] storage constant x, uint[] memory y) internal { } | |||
There was a problem hiding this comment.
storage constant is invalid (Storage location has to be "memory" (or unspecified) for constants.). Should we leave it as an error or use constant rather on the memory argument?
There was a problem hiding this comment.
I would leave it like it is.
| function fun(uint a) returns(uint r) { return a; } | ||
| } | ||
| )"; | ||
| // with support of overloaded functions, during parsing, |
There was a problem hiding this comment.
This should not be removed.
There was a problem hiding this comment.
I can add them back, though they are not relevant since syntax tests run the analysis phase.
There was a problem hiding this comment.
ok right, I actually didn't read the comment, just saw that it was not retained :)
chriseth
left a comment
There was a problem hiding this comment.
Fine apart from the missing comments. I did not check the tests in details nor did I count them.
|
Added back the comment, but I think it is not needed there. I did manually verify the test cases (the proper ones removed and proper expectations, compared to the old version, but any extra eyes are welcome. |
|
@axic Looks good to me. I counted 52 tests that have been removed and 54 that have been added, so I guess there're all covered ;) |
|
I would say we should merge this first and then update the tests to 0.5.0 syntax, i.e. add public and stuff. Of course only if that is not the issue under test. |
Yes, that would be the best approach, these are only moving test cases (mostly) verbatim, 0.5.0 fixes should be applied after. |
No description provided.