Merged
Conversation
axic
reviewed
May 8, 2018
docs/grammar.txt
Outdated
| ( 'returns' FunctionTypeParameterList )? | ||
| StorageLocation = 'memory' | 'storage' | ||
| StateMutability = 'pure' | 'constant' | 'view' | 'payable' | ||
| StateMutability = 'pure' | 'view' | 'payable' |
Collaborator
Author
There was a problem hiding this comment.
OK - the idea of this (and the one's below) was to already update the documentation as if constant had already been removed and only mentioning it's existence in a note, but you're probably right that it's better to postpone that until the breaking change.
axic
reviewed
May 8, 2018
| - ``view`` for functions: Disallows modification of state - this is not enforced yet. | ||
| - ``payable`` for functions: Allows them to receive Ether together with a call. | ||
| - ``constant`` for state variables: Disallows assignment (except initialisation), does not occupy storage slot. | ||
| - ``constant`` for functions: Same as ``view``. |
axic
reviewed
May 8, 2018
docs/types.rst
Outdated
| Function types are notated as follows:: | ||
|
|
||
| function (<parameter types>) {internal|external} [pure|constant|view|payable] [returns (<return types>)] | ||
| function (<parameter types>) {internal|external} [pure|view|payable] [returns (<return types>)] |
9f68c04 to
bb56248
Compare
bb56248 to
9055b9c
Compare
0ad10dc to
a6a8b0f
Compare
axic
previously approved these changes
May 9, 2018
a6a8b0f to
bc47265
Compare
Contributor
|
Rebased after #4104. |
axic
previously approved these changes
May 9, 2018
Contributor
|
@chriseth OK with this? (mostly the documentation changes) |
Collaborator
Author
|
@axic I added another commit that removes |
e313466 to
9b7ded2
Compare
chriseth
approved these changes
May 14, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2502.
Adjust tests, documentation, style guide, std contracts in preparation of #4090.
This is the non-breaking subset of #4090.