Do not warn about 0.5.0 experimental pragma.#3600
Merged
Conversation
axic
reviewed
Feb 26, 2018
Changelog.md
Outdated
| * Type Checker: Disallow uninitialized storage pointers as experimental 0.5.0 feature. | ||
| * Support and recommend using ``emit EventName();`` to call events explicitly. | ||
| * Syntax Analyser: Do not warn about experimental features if they do not concern code generation. | ||
| * Syntax Analyser: Do not warn about `pragma experimental "v0.5.0"`. |
Contributor
There was a problem hiding this comment.
I would extend it: "since they do not affect code generation". I know it is stated above, but better to be explicit.
8560e00 to
ef7bcff
Compare
Contributor
Author
|
Changed. |
69073f2 to
c747d24
Compare
axic
reviewed
Mar 2, 2018
Changelog.md
Outdated
| * Type Checker: Disallow uninitialized storage pointers as experimental 0.5.0 feature. | ||
| * Support and recommend using ``emit EventName();`` to call events explicitly. | ||
| * Syntax Analyser: Do not warn about experimental features if they do not concern code generation. | ||
| * Syntax Analyser: Do not warn about `pragma experimental "v0.5.0"` since it does not affect code generation. |
c747d24 to
477571e
Compare
Contributor
Author
|
Updated. |
Contributor
Author
|
No, it's the other way round. |
Contributor
I don't think so, #3599 removed the last non-analysis-only 0.5.0 change. |
Contributor
Author
|
ah that way! sorry! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3576
Depends on #3599.