-
Notifications
You must be signed in to change notification settings - Fork 6.1k
External dependencies: json-cpp, fmtlib, ranges-v3, intx, z3, cvc4 #8860
Copy link
Copy link
Closed as not planned
Closed as not planned
Copy link
Labels
build system 🏗️closed due inactivityThe issue/PR was automatically closed due to inactivity.The issue/PR was automatically closed due to inactivity.low effortThere is not much implementation work to be done. The task is very easy or tiny.There is not much implementation work to be done. The task is very easy or tiny.medium impactDefault level of impactDefault level of impactstaleThe issue/PR was marked as stale because it has been open for too long.The issue/PR was marked as stale because it has been open for too long.
Metadata
Metadata
Assignees
Labels
build system 🏗️closed due inactivityThe issue/PR was automatically closed due to inactivity.The issue/PR was automatically closed due to inactivity.low effortThere is not much implementation work to be done. The task is very easy or tiny.There is not much implementation work to be done. The task is very easy or tiny.medium impactDefault level of impactDefault level of impactstaleThe issue/PR was marked as stale because it has been open for too long.The issue/PR was marked as stale because it has been open for too long.
Situation:
ExternalProject_Addmechanismfind_package.Issues with
ExternalProject_Add:makerequires a network connection and starts downloadingApart from boost, all the other dependencies except json-cpp (including nlohmann/json as potential json-cpp replacement) are header-only or nearly header-only.
When considering to add new dependencies we could:
ExternalProject_Addmechanism despite its drawbacks.git submodulesfor the new dependencies (or all dependencies).submodulesusesubtrees.find_package, while maintaining a betterìnstall_depsscript to locally install dependencies in the build tree.find_packagewith other mechanisms as fallback.