Skip to content

chore: add canaryStepString route msg#4490

Merged
zachaller merged 2 commits into
argoproj:masterfrom
hnnynh:util-canary-step-string-route
Nov 2, 2025
Merged

chore: add canaryStepString route msg#4490
zachaller merged 2 commits into
argoproj:masterfrom
hnnynh:util-canary-step-string-route

Conversation

@hnnynh

@hnnynh hnnynh commented Oct 15, 2025

Copy link
Copy Markdown
Contributor

I’ve been seeing log messages with (invalid) when the setHeaderRoute step completes, so I added a Routing CanaryStepString field to improve log readability.

  • AS-IS:
Rollout step n/n completed (invalid)
  • TO-BE:
Rollout step n/n completed (setHeaderRoute: foo)

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@hnnynh hnnynh marked this pull request as ready for review October 15, 2025 03:38
@github-actions

github-actions Bot commented Oct 15, 2025

Copy link
Copy Markdown
Contributor

Published E2E Test Results

  4 files    4 suites   3h 22m 25s ⏱️
117 tests 108 ✅  7 💤 2 ❌
470 runs  440 ✅ 28 💤 2 ❌

For more details on these failures, see this check.

Results for commit 56de9bf.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Oct 15, 2025

Copy link
Copy Markdown
Contributor

Published Unit Test Results

2 351 tests   2 351 ✅  3m 2s ⏱️
  129 suites      0 💤
    1 files        0 ❌

Results for commit 56de9bf.

♻️ This comment has been updated with latest results.

uno added 2 commits October 16, 2025 09:14
Signed-off-by: uno <uno@daangn.com>
Signed-off-by: uno <uno@daangn.com>
@hnnynh hnnynh force-pushed the util-canary-step-string-route branch from b5de1c4 to 56de9bf Compare October 16, 2025 00:14
@sonarqubecloud

Copy link
Copy Markdown

@zachaller zachaller merged commit dd27d78 into argoproj:master Nov 2, 2025
24 checks passed
@hnnynh hnnynh deleted the util-canary-step-string-route branch November 3, 2025 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants