feat(argo-rollouts): Add first-class values for missing controller and dashboard flags#3799
Merged
jmeridth merged 4 commits intoargoproj:mainfrom Mar 26, 2026
Conversation
819f6ea to
555c032
Compare
tico24
requested changes
Mar 22, 2026
Member
tico24
left a comment
There was a problem hiding this comment.
Put this PR into draft. Re-add the checklist that you allowed your LLM to delete and then follow it.
Humans review these PRs, it's common decency for you to review the work of your LLM yourself before asking others to.
Member
|
@DrFaust92 please add the PR template content to this PR's description. Thank you for your contribution. |
…d dashboard flags - Add AWS EKS Auto Mode support: awsVerifyTargetGroup, awsTargetGroupBindingAPIVersion, albTagKeyResourceID - Add self-service notification flag: selfServiceNotification - Add pprof profiling address: pprofAddress - Add dashboard rootPath for reverse proxy setups Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Ilia <ilia.lazebnik@gmail.com>
555c032 to
9b93aaa
Compare
Signed-off-by: Ilia Lazebnik <ilia.lazebnik@gmail.com> Signed-off-by: Ilia <ilia.lazebnik@placer.ai>
Signed-off-by: Ilia Lazebnik <ilia.lazebnik@gmail.com> Signed-off-by: Ilia <ilia.lazebnik@placer.ai>
Contributor
Author
Thanks @jmeridth , done |
yu-croco
approved these changes
Mar 26, 2026
jmeridth
approved these changes
Mar 26, 2026
tico24
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
Summary
The chart currently only exposes a handful of controller/dashboard CLI flags as dedicated values, requiring users to discover and use
extraArgsfor many important features. This PR adds first-class support for high-priority flags that were identified as gaps across v1.6.0–v1.9.0:controller.awsVerifyTargetGroup,controller.awsTargetGroupBindingAPIVersion,controller.albTagKeyResourceID) — Critical for EKS Auto Mode users who needeks.amazonaws.com/v1API version instead ofelbv2.k8s.aws/v1beta1. Resolves the issue described in argo-rollouts#4368.controller.selfServiceNotification) — Enables per-namespace notification config, available since v1.6.0. The chart already has anotificationssection but never exposed this flag.controller.pprofAddress) — Added in v1.8.0 (argo-rollouts#3769), allows enabling pprof profiling on the controller.dashboard.rootPath) — Fixed in v1.9.0 (argo-rollouts#4430), important for running the dashboard behind a reverse proxy with a path prefix.All new values default to empty/false, so this is fully backwards compatible — no args are added unless explicitly set.
Test plan
helm templatewith all new values set renders correct CLI argshelm templatewith defaults renders no extra args (backwards compatible)controller.awsVerifyTargetGroup=true+awsTargetGroupBindingAPIVersionon EKS Auto Modecontroller.selfServiceNotification=trueand per-namespace notification configdashboard.rootPathbehind ingress with path prefix🤖 Generated with Claude Code