fix(argo-cd): Fix typo in changelog message for 9.0.0#3545
fix(argo-cd): Fix typo in changelog message for 9.0.0#3545tgdfool2 wants to merge 2 commits intoargoproj:mainfrom
Conversation
Signed-off-by: Olivier Fournier, INI-CIT-ICL <Olivier.Fournier@swisscom.com>
d0b066b to
dee8a2a
Compare
Signed-off-by: Olivier Fournier, INI-CIT-ICL <Olivier.Fournier@swisscom.com>
752dbcf to
18d9daa
Compare
|
Thank you for your PR.
|
| configs: | ||
| cm: | ||
| params: | ||
| applicationsetcontroller.policy: 'sync' |
There was a problem hiding this comment.
Can you please also fix this?
| configs: | |
| params: | |
| applicationsetcontroller.policy: 'sync' |
There was a problem hiding this comment.
I think that this one is correct, no? All the configs.params value have been replaced, and should now be replaced with the corresponding ones under configs.cm.params, no? So I think that the doc is correct. Or am I missing something?
There was a problem hiding this comment.
GitHub doesn't render correctly suggestion... We removed configs.params.xxxx not configs.cm.params.xxxx (e.g. configs.params."application.namespaces" ), so we want to fix like below.
current:
configs:
cm:
params:
applicationsetcontroller.policy: 'sync'fixed one:
configs:
params:
applicationsetcontroller.policy: 'sync'
There was a problem hiding this comment.
*We removed from values.yaml but users can override the same way as older version.
There was a problem hiding this comment.
*We removed from values.yaml but users can override the same way as older version.
This means that the following configuration remains valid, right?
There was a problem hiding this comment.
You mean you askedabout server.insecure ? If so, yes this is the right config.
Of course, I'll fix this in a couple of minutes. |
Checklist: