feat(argocd-apps): finalizers for applicationset#2952
Merged
mkilchhofer merged 3 commits intoargoproj:mainfrom Oct 1, 2024
Merged
feat(argocd-apps): finalizers for applicationset#2952mkilchhofer merged 3 commits intoargoproj:mainfrom
mkilchhofer merged 3 commits intoargoproj:mainfrom
Conversation
Signed-off-by: Maneesh Singh <mann.biher@yahoo.co.in>
mkilchhofer
reviewed
Sep 30, 2024
Member
mkilchhofer
left a comment
There was a problem hiding this comment.
Almost LGTM.
Can you please remove the changelog lines from the previous release?
Comment on lines
+22
to
+24
| artifacthub.io/changes: | | ||
| - kind: added | ||
| description: allow setting applicationset finalizers |
Member
There was a problem hiding this comment.
line 19..21 needs to be removed
Contributor
Author
There was a problem hiding this comment.
Restored wrong deletion. Now the Chart changelog reflects current release changes.
Signed-off-by: Maneesh Singh <mann.biher@yahoo.co.in>
Signed-off-by: Maneesh Singh <mann.biher@yahoo.co.in>
yu-croco
approved these changes
Oct 1, 2024
Collaborator
yu-croco
left a comment
There was a problem hiding this comment.
Thank you for your contribution. LGTM.
mkilchhofer
approved these changes
Oct 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2951
Checklist: