Skip to content

fix(argo-events): Fix events-webhook Service using non-default port#2929

Merged
yu-croco merged 1 commit intoargoproj:mainfrom
nhavens:main
Sep 20, 2024
Merged

fix(argo-events): Fix events-webhook Service using non-default port#2929
yu-croco merged 1 commit intoargoproj:mainfrom
nhavens:main

Conversation

@nhavens
Copy link
Copy Markdown
Contributor

@nhavens nhavens commented Sep 19, 2024

Resolves #2926

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

Resolves argoproj#2926

Signed-off-by: Neile Havens <neilehavens@gmail.com>
@tico24
Copy link
Copy Markdown
Member

tico24 commented Sep 19, 2024

Looks good to me (other than the DCO arguing that's required)

@nhavens
Copy link
Copy Markdown
Contributor Author

nhavens commented Sep 19, 2024

Looks good to me (other than the DCO arguing that's required)

Thanks for the quick approval! I believe I've corrected the DCO issue.

@nhavens
Copy link
Copy Markdown
Contributor Author

nhavens commented Sep 19, 2024

@tico24 All checks are green now.

Copy link
Copy Markdown
Collaborator

@yu-croco yu-croco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@yu-croco yu-croco merged commit 8adc293 into argoproj:main Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modifying the default webhook port breaks the validatingwebhookconfiguration

3 participants