WiFiC3 - macAddress() return normal bytes ordering#184
Merged
aentinger merged 1 commit intoarduino:mainfrom Dec 14, 2023
Merged
WiFiC3 - macAddress() return normal bytes ordering#184aentinger merged 1 commit intoarduino:mainfrom
aentinger merged 1 commit intoarduino:mainfrom
Conversation
BSSID was not reversed so examples printed it reversed.
Contributor
Because they way it has been done before has been wrong? I'd rather fix all old libraries than "wrong" the correct implementation. What do you think? |
Contributor
Author
|
this library has reversed ordering too. reversed ordering is wrong. this PR does normal ordering for this library |
aentinger
approved these changes
Dec 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The firmware of the first WiFi library returned the MAC address in reversed ordering. It was fixed in examples and not in the
macAddressmethod. Since then every WiFi library by Arduino reverses the MAC address inmacAddressto reversed ordering and some reverse BSSID too. Then the examples print it reversed.Why continue with this in new libraries?
here BSSID was not reversed so examples printed it reversed.
overview of WiFi/Ethernet getters and setters:
https://github.com/JAndrassy/Arduino-Networking-API/blob/main/ArduinoNetAPILibs.md#network-interface-getters-and-setters