You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated.
#2079 090b4b0
Thanks @ardatan! - Fix the bug when set-cookies given is ignored
in HeadersInit;
import{Headers}from'@whatwg-node/fetch'constheaders=newHeaders([['set-cookie','a=b'],['set-cookie','c=d']])expect(headers.getSetCookie()).toEqual(['a=b','c=d'])// Previously it was empty
#2079 090b4b0
Thanks @ardatan! - Fix the bug when set-cookies given is ignored
in HeadersInit;
import{Headers}from'@whatwg-node/fetch'constheaders=newHeaders([['set-cookie','a=b'],['set-cookie','c=d']])expect(headers.getSetCookie()).toEqual(['a=b','c=d'])// Previously it was empty
This pull request removes several changelog files and updates version numbers and dependency versions for multiple packages. The changes include dependency bumps for packages such as @whatwg-node/fetch, @whatwg-node/node-fetch, @whatwg-node/server, and related plugins across benchmarks, end-to-end tests, and core packages. A bug fix addressing the handling of multiple set-cookie headers in the HeadersInit interface is also documented. No changes were made to public API declarations.
Updated version from 1.0.3 to 1.0.4; dependency on @whatwg-node/server updated from ^0.9.67 to ^0.9.68; updated @whatwg-node/cookie-store to 0.2.2 and removed outdated peer dependency.
packages/server/{CHANGELOG.md,package.json}
Version updated from 0.9.67 to 0.9.68; updated @whatwg-node/fetch from ^0.10.3 to ^0.10.4 with corresponding changelog entries.
Possibly related PRs
Align versions #2082: Direct dependency updates for @whatwg-node/fetch and @whatwg-node/node-fetch align with this PR.
Upcoming Release Changes #2050: Addresses the set-cookie handling in the HeadersInit interface, similar to the bug fix documented here.
I'm a rabbit on a joyful spree,
Hopping through code with glee and tea.
Dependencies updated with a skip and a leap,
Bugs fixed in cookies, no promises to keep.
Crunching code like carrots so sweet—
A merry hop in every commit!
🥕🐇
📜 Recent review details
Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between b217e30 and 0b4738c.
✅ Files skipped from review due to trivial changes (12)
packages/node-fetch/package.json
e2e/shared-server/CHANGELOG.md
benchmarks/server/CHANGELOG.md
e2e/aws-lambda/package.json
e2e/aws-lambda/CHANGELOG.md
packages/fetch/package.json
e2e/vercel/CHANGELOG.md
benchmarks/server/package.json
e2e/vercel/package.json
packages/server/package.json
e2e/shared-server/package.json
packages/server-plugin-cookies/package.json
⏰ Context from checks skipped due to timeout of 90000ms (11)
GitHub Check: unit / node 23
GitHub Check: unit / node 22
GitHub Check: unit / deno
GitHub Check: unit / node 20
GitHub Check: server (undici)
GitHub Check: unit / bun
GitHub Check: server (ponyfill)
GitHub Check: unit / node 18
GitHub Check: node-fetch (consumeBody)
GitHub Check: e2e / azure-function
GitHub Check: server (native)
🔇 Additional comments (4)
packages/server-plugin-cookies/CHANGELOG.md (1)
3-22: Changelog Entry for Version 1.0.4:
This new entry documents the dependency updates in the @whatwg-node/server-plugin-cookies package. It clearly specifies:
– The upgrade of @whatwg-node/cookie-store to version ^0.2.2 in dependencies.
– The addition of @whatwg-node/server at version ^0.9.67 to dependencies, while removing the older version (^0.9.44) from peerDependencies.
– The subsequent update of @whatwg-node/server to version 0.9.68 as part of the overall dependency refresh.
Please ensure that these changelog details accurately mirror the changes in the package manifest and that all version numbers and dependency removals/additions are consistent with the repository’s release notes.
packages/fetch/CHANGELOG.md (1)
3-32: Changelog Entry for Version 0.10.4:
This entry highlights two key updates:
– A dependency update for @whatwg-node/node-fetch (from ^0.7.8 to ^0.7.9, later bumped to 0.7.10) in the context of the package’s dependencies.
– A critical bug fix addressing the issue where multiple set-cookie headers in HeadersInit were previously ignored. The included code snippet demonstrates the correct behavior with output showing both cookies.
Verify that the presented example accurately reflects runtime behavior, and ensure that the dependency updates are aligned with those in related packages.
packages/node-fetch/CHANGELOG.md (1)
3-20: Changelog Entry for Version 0.7.10:
The new changelog entry for version 0.7.10 fixes the bug where multiple set-cookie headers were being ignored in HeadersInit. It includes a concise code snippet to illustrate the expected behavior using the updated functionality of Headers.getSetCookie().
Double-check that the dependency reference and commit IDs are correct and that this update is consistently propagated wherever the @whatwg-node/node-fetch package is used.
packages/server/CHANGELOG.md (1)
3-16: Changelog Entry for Version 0.9.68:
This entry records the updates made to the server package’s dependencies:
– The dependency on @whatwg-node/fetch has been updated from ^0.10.0 to ^0.10.3, and then further bumped to 0.10.4 via the referenced commits.
– The commit links and acknowledgments (e.g. [#2082]) confirm the source of these changes.
It is important to confirm that these dependency updates are consistent across all related packages (such as those in the plugins and benchmarks) and that any behavioral changes (e.g. for plugin responses) are well documented.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>, please review it.
Generate unit testing code for this file.
Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
@coderabbitai generate unit testing code for this file.
@coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
@coderabbitai read src/utils.ts and generate unit testing code.
@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
@coderabbitai help me debug CodeRabbit configuration file.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated.
Releases
@whatwg-node/fetch@0.10.4
Patch Changes
#2082
b217e30Thanks @ardatan! - dependencies updates:
@whatwg-node/node-fetch@^0.7.9↗︎(from
^0.7.8, independencies)#2079
090b4b0Thanks @ardatan! - Fix the bug when
set-cookiesgiven is ignoredin
HeadersInit;Updated dependencies
[
090b4b0]:@whatwg-node/node-fetch@0.7.10
Patch Changes
#2079
090b4b0Thanks @ardatan! - Fix the bug when
set-cookiesgiven is ignoredin
HeadersInit;@whatwg-node/server@0.9.68
Patch Changes
b217e30Thanks @ardatan! - dependencies updates:
@whatwg-node/fetch@^0.10.3↗︎(from
^0.10.0, independencies)[
b217e30,090b4b0]:@whatwg-node/server-plugin-cookies@1.0.4
Patch Changes
b217e30Thanks @ardatan! - dependencies updates:
@whatwg-node/cookie-store@^0.2.2↗︎(from
0.2.2, independencies)@whatwg-node/server@^0.9.67↗︎(to
dependencies)@whatwg-node/server@^0.9.44↗︎(from
peerDependencies)[
b217e30]:@benchmarks/server@0.0.43
Patch Changes
[
b217e30]:@e2e/aws-lambda@0.0.38
Patch Changes
[
b217e30,090b4b0]:@e2e/shared-server@0.0.131
Patch Changes
[
b217e30,b217e30,090b4b0]:@e2e/vercel@0.0.131
Patch Changes
Summary by CodeRabbit
Bug Fixes
Chores