Upcoming Release Changes by theguild-bot · Pull Request #2032 · ardatan/whatwg-node

theguild-bot · 2025-02-05T16:07:02Z

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated.

Releases

@whatwg-node/node-fetch@0.7.8

Patch Changes

337e605
Thanks @ardatan! - - Use native AbortSignal and AbortController for
Request.signal
- Remove custom AbortSignal implementation (ServerAdapterAbortSignal)

@whatwg-node/server@0.9.66

Patch Changes

337e605
Thanks @ardatan! - - Use native AbortSignal and AbortController for
Request.signal
- Remove custom AbortSignal implementation (ServerAdapterAbortSignal)

@benchmarks/server@0.0.41

Patch Changes

Updated dependencies
[337e605]:
- @whatwg-node/server@0.9.66

@e2e/shared-server@0.0.129

Patch Changes

Updated dependencies
[337e605]:
- @whatwg-node/server@0.9.66

@e2e/vercel@0.0.129

Patch Changes

Updated dependencies []:
- @e2e/shared-server@0.0.129

Summary by CodeRabbit

Refactor
- Streamlined request cancellation by adopting standard native APIs, enhancing reliability and error management.
Chores
- Performed version bumps and dependency updates across multiple modules, ensuring improved integration consistency.

coderabbitai · 2025-02-05T16:07:11Z

Caution

Review failed

The pull request is closed.

Walkthrough

This update removes a custom implementation of abort signals and replaces it with native browser APIs (AbortSignal and AbortController) for both the server and node-fetch packages. Several package and changelog version numbers have been incremented, and dependency versions have been updated across the benchmarks, end-to-end, and packages directories to reflect these changes.

Changes

File(s)	Change Summary
`.changeset/metal-moles-care.md`, `packages/node-fetch/CHANGELOG.md`, `packages/server/CHANGELOG.md`	Removed custom `ServerAdapterAbortSignal` and adopted native `AbortSignal`/`AbortController` for request cancellation handling.
`benchmarks/server/CHANGELOG.md`, `benchmarks/server/package.json`	Bumped version to `0.0.41` and updated dependency `@whatwg-node/server` from `0.9.65` to `0.9.66`.
`e2e/shared-server/CHANGELOG.md`, `e2e/shared-server/package.json`	Bumped version to `0.0.129` and updated dependency `@whatwg-node/server` from `0.9.65` to `0.9.66`.
`e2e/vercel/CHANGELOG.md`, `e2e/vercel/package.json`	Bumped version to `0.0.129` and updated dependency `@e2e/shared-server` from `0.0.128` to `0.0.129`.
`packages/node-fetch/package.json`	Updated version from `0.7.7` to `0.7.8`.
`packages/server/package.json`	Updated version from `0.9.65` to `0.9.66`.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant Server
    participant AbortController
    Client->>Server: Send request with AbortSignal
    Server->>AbortController: Initialize and monitor signal
    alt Cancellation triggered
        AbortController-->>Server: Abort signal activated
        Server-->>Client: Return cancellation error/notice
    else Process request
        Server-->>Client: Return successful response
    end

Possibly related PRs

enhance(server): use native AbortController and AbortSignal #2031: Addresses similar changes by removing the custom ServerAdapterAbortSignal and integrating native AbortSignal/AbortController for managing request cancellations.

Poem

I'm a rabbit hopping through lines of code,
Delighting in changes down the debugging road.
The custom abort is now a tale of yore,
Native signals clear, simple, and pure.
My heart does a leap with each version we embrace,
Coding adventures with a smile on my face!
🥕 Keep hopping and coding with elegance and grace!

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 337e605 and 234502a.

📒 Files selected for processing (11)

.changeset/metal-moles-care.md (0 hunks)
benchmarks/server/CHANGELOG.md (1 hunks)
benchmarks/server/package.json (2 hunks)
e2e/shared-server/CHANGELOG.md (1 hunks)
e2e/shared-server/package.json (1 hunks)
e2e/vercel/CHANGELOG.md (1 hunks)
e2e/vercel/package.json (2 hunks)
packages/node-fetch/CHANGELOG.md (1 hunks)
packages/node-fetch/package.json (1 hunks)
packages/server/CHANGELOG.md (1 hunks)
packages/server/package.json (1 hunks)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-02-05T16:09:06Z

🚀 Snapshot Release (`rc`)

The latest changes of this PR are available as rc on npm (based on the declared changesets):

Package	Version	Info
`@whatwg-node/node-fetch`	`0.7.8-rc-20250205161008-234502a36574e58cd24a1ee00814dcf6a1b94601`	npm ↗︎ unpkg ↗︎
`@whatwg-node/server`	`0.9.66-rc-20250205161008-234502a36574e58cd24a1ee00814dcf6a1b94601`	npm ↗︎ unpkg ↗︎

github-actions · 2025-02-05T16:10:26Z

✅ `@benchmarks/node-fetch` results (consumeBody)

   ✓ active_handles.................: avg=140.8932 min=25      med=140     max=175     p(90)=162     p(95)=165    
     data_received..................: 20 MB  659 kB/s
     data_sent......................: 13 MB  422 kB/s
     http_req_blocked...............: avg=3.16µs   min=591ns   med=1.37µs  max=5.91ms  p(90)=2.08µs  p(95)=2.39µs 
     http_req_connecting............: avg=1.1µs    min=0s      med=0s      max=3.82ms  p(90)=0s      p(95)=0s     
     http_req_duration..............: avg=23.14ms  min=2.99ms  med=22.33ms max=1.22s   p(90)=28.95ms p(95)=31.01ms
       { expected_response:true }...: avg=23.14ms  min=2.99ms  med=22.33ms max=1.22s   p(90)=28.95ms p(95)=31.01ms
     http_req_failed................: 0.00%  ✓ 0           ✗ 129180
     http_req_receiving.............: avg=35.57µs  min=9.49µs  med=25.89µs max=20.52ms p(90)=40.14µs p(95)=47.03µs
     http_req_sending...............: avg=11.74µs  min=3.3µs   med=6.93µs  max=13.8ms  p(90)=10.8µs  p(95)=14.84µs
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s      max=0s      p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=23.1ms   min=2.95ms  med=22.28ms max=1.22s   p(90)=28.9ms  p(95)=30.96ms
     http_reqs......................: 129180 4305.197572/s
     iteration_duration.............: avg=46.41ms  min=13.92ms med=44.58ms max=1.25s   p(90)=51.06ms p(95)=56.56ms
     iterations.....................: 64569  2151.898917/s
     vus............................: 100    min=100       max=100 
     vus_max........................: 100    min=100       max=100

github-actions · 2025-02-05T16:10:33Z

✅ `@benchmarks/node-fetch` results (noConsumeBody)

   ✓ active_handles.................: avg=139.830329 min=12      med=138     max=182     p(90)=164     p(95)=169    
     data_received..................: 21 MB  703 kB/s
     data_sent......................: 14 MB  456 kB/s
     http_req_blocked...............: avg=1.98µs     min=631ns   med=1.32µs  max=5.1ms   p(90)=2µs     p(95)=2.23µs 
     http_req_connecting............: avg=252ns      min=0s      med=0s      max=3.12ms  p(90)=0s      p(95)=0s     
     http_req_duration..............: avg=21.68ms    min=3.85ms  med=21.01ms max=1.16s   p(90)=27.45ms p(95)=29.15ms
       { expected_response:true }...: avg=21.68ms    min=3.85ms  med=21.01ms max=1.16s   p(90)=27.45ms p(95)=29.15ms
     http_req_failed................: 0.00%  ✓ 0          ✗ 137941
     http_req_receiving.............: avg=31.45µs    min=9.43µs  med=22.9µs  max=15.32ms p(90)=37.04µs p(95)=43.21µs
     http_req_sending...............: avg=9.72µs     min=3.38µs  med=6.2µs   max=12.63ms p(90)=9.64µs  p(95)=12.69µs
     http_req_tls_handshaking.......: avg=0s         min=0s      med=0s      max=0s      p(90)=0s      p(95)=0s     
     http_req_waiting...............: avg=21.64ms    min=3.79ms  med=20.98ms max=1.16s   p(90)=27.41ms p(95)=29.1ms 
     http_reqs......................: 137941 4597.51885/s
     iteration_duration.............: avg=43.46ms    min=11.65ms med=41.8ms  max=1.18s   p(90)=47.69ms p(95)=53.27ms
     iterations.....................: 68945  2297.90952/s
     vus............................: 100    min=100      max=100 
     vus_max........................: 100    min=100      max=100

github-actions · 2025-02-05T16:10:54Z

✅ `@benchmarks/server` results (native)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 208906      ✗ 0     
     data_received..................: 21 MB   700 kB/s
     data_sent......................: 8.4 MB  279 kB/s
     http_req_blocked...............: avg=1.4µs    min=892ns    med=1.19µs   max=261.33µs p(90)=1.88µs   p(95)=2.04µs  
     http_req_connecting............: avg=1ns      min=0s       med=0s       max=117.85µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=224.46µs min=172.44µs med=213.84µs max=7.66ms   p(90)=241.76µs p(95)=252.26µs
       { expected_response:true }...: avg=224.46µs min=172.44µs med=213.84µs max=7.66ms   p(90)=241.76µs p(95)=252.26µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 104453
     http_req_receiving.............: avg=25.01µs  min=13.89µs  med=23.24µs  max=2.53ms   p(90)=30.38µs  p(95)=33µs    
     http_req_sending...............: avg=6.38µs   min=3.98µs   med=5.51µs   max=2.49ms   p(90)=8.15µs   p(95)=8.84µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=193.07µs min=147.89µs med=182.09µs max=7.61ms   p(90)=207.16µs p(95)=216.77µs
     http_reqs......................: 104453  3481.653184/s
     iteration_duration.............: avg=282.74µs min=215.95µs med=271.46µs max=7.74ms   p(90)=302.69µs p(95)=315.66µs
     iterations.....................: 104453  3481.653184/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1

github-actions · 2025-02-05T16:11:01Z

✅ `@benchmarks/server` results (ponyfill)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 295328      ✗ 0     
     data_received..................: 29 MB   970 kB/s
     data_sent......................: 12 MB   394 kB/s
     http_req_blocked...............: avg=1.4µs    min=861ns    med=1.18µs   max=208.97µs p(90)=1.9µs    p(95)=2.08µs  
     http_req_connecting............: avg=0ns      min=0s       med=0s       max=128.97µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=140.4µs  min=95.15µs  med=135.53µs max=7.32ms   p(90)=157.87µs p(95)=165.47µs
       { expected_response:true }...: avg=140.4µs  min=95.15µs  med=135.53µs max=7.32ms   p(90)=157.87µs p(95)=165.47µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 147664
     http_req_receiving.............: avg=24.59µs  min=11.87µs  med=22.99µs  max=2.56ms   p(90)=30.34µs  p(95)=33.2µs  
     http_req_sending...............: avg=6.42µs   min=4.05µs   med=5.58µs   max=493.81µs p(90)=8.22µs   p(95)=9.14µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=109.38µs min=69.11µs  med=104.3µs  max=7.21ms   p(90)=123.55µs p(95)=129.78µs
     http_reqs......................: 147664  4921.962238/s
     iteration_duration.............: avg=198.67µs min=141.59µs med=193.06µs max=7.61ms   p(90)=218.84µs p(95)=228.52µs
     iterations.....................: 147664  4921.962238/s
     vus............................: 1       min=1         max=1   
     vus_max........................: 1       min=1         max=1

github-actions · 2025-02-05T16:11:02Z

✅ `@benchmarks/server` results (undici)

     ✓ no-errors
     ✓ expected-result

   ✓ checks.........................: 100.00% ✓ 189700      ✗ 0    
     data_received..................: 19 MB   636 kB/s
     data_sent......................: 7.6 MB  253 kB/s
     http_req_blocked...............: avg=1.44µs   min=892ns    med=1.21µs   max=171.86µs p(90)=1.95µs   p(95)=2.13µs  
     http_req_connecting............: avg=1ns      min=0s       med=0s       max=126.67µs p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=250.68µs min=189.93µs med=237.14µs max=32.92ms  p(90)=265.96µs p(95)=277.77µs
       { expected_response:true }...: avg=250.68µs min=189.93µs med=237.14µs max=32.92ms  p(90)=265.96µs p(95)=277.77µs
     http_req_failed................: 0.00%   ✓ 0           ✗ 94850
     http_req_receiving.............: avg=26.41µs  min=14.25µs  med=24.4µs   max=3.24ms   p(90)=32.15µs  p(95)=35.11µs 
     http_req_sending...............: avg=6.73µs   min=4.18µs   med=6.14µs   max=321.58µs p(90)=8.48µs   p(95)=9.54µs  
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=217.53µs min=163.79µs med=204.29µs max=32.86ms  p(90)=229.73µs p(95)=240.18µs
     http_reqs......................: 94850   3161.559113/s
     iteration_duration.............: avg=311.52µs min=234.81µs med=296.83µs max=33.04ms  p(90)=330.06µs p(95)=344.56µs
     iterations.....................: 94850   3161.559113/s
     vus............................: 1       min=1         max=1  
     vus_max........................: 1       min=1         max=1

theguild-bot force-pushed the changeset-release/master branch from 48b5086 to 839fd9f Compare February 5, 2025 16:07

chore(release): update monorepo packages versions

234502a

theguild-bot force-pushed the changeset-release/master branch from 839fd9f to 234502a Compare February 5, 2025 16:08

ardatan merged commit aecdc2e into master Feb 5, 2025

This was referenced Feb 20, 2025

Align versions #2082

Merged

fix(node-fetch/http2): handle Http2 streams correctly #2093

Merged

Upcoming Release Changes #2098

Merged

coderabbitai bot mentioned this pull request Mar 21, 2025

fix(server): do not hang when server adapter's request is leaked and attempted to parse outside #2208

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Upcoming Release Changes#2032

Upcoming Release Changes#2032
ardatan merged 1 commit intomasterfrom
changeset-release/master

theguild-bot commented Feb 5, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Feb 5, 2025 •

edited

Loading

Review failed

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

github-actions bot commented Feb 5, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Feb 5, 2025

Uh oh!

github-actions bot commented Feb 5, 2025

Uh oh!

github-actions bot commented Feb 5, 2025

Uh oh!

github-actions bot commented Feb 5, 2025

Uh oh!

github-actions bot commented Feb 5, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

theguild-bot commented Feb 5, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Releases

@whatwg-node/node-fetch@0.7.8

Patch Changes

@whatwg-node/server@0.9.66

Patch Changes

@benchmarks/server@0.0.41

Patch Changes

@e2e/shared-server@0.0.129

Patch Changes

@e2e/vercel@0.0.129

Patch Changes

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Feb 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions bot commented Feb 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Snapshot Release (rc)

Uh oh!

github-actions bot commented Feb 5, 2025

✅ @benchmarks/node-fetch results (consumeBody)

Uh oh!

github-actions bot commented Feb 5, 2025

✅ @benchmarks/node-fetch results (noConsumeBody)

Uh oh!

github-actions bot commented Feb 5, 2025

✅ @benchmarks/server results (native)

Uh oh!

github-actions bot commented Feb 5, 2025

✅ @benchmarks/server results (ponyfill)

Uh oh!

github-actions bot commented Feb 5, 2025

✅ @benchmarks/server results (undici)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

theguild-bot commented Feb 5, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 5, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

github-actions bot commented Feb 5, 2025 •

edited

Loading

🚀 Snapshot Release (`rc`)

✅ `@benchmarks/node-fetch` results (consumeBody)

✅ `@benchmarks/node-fetch` results (noConsumeBody)

✅ `@benchmarks/server` results (native)

✅ `@benchmarks/server` results (ponyfill)

✅ `@benchmarks/server` results (undici)