test(arcjet): add tests for allowing and denying invalid emails#5769
Merged
trunk-io[bot] merged 1 commit intomainfrom Feb 3, 2026
Merged
test(arcjet): add tests for allowing and denying invalid emails#5769trunk-io[bot] merged 1 commit intomainfrom
trunk-io[bot] merged 1 commit intomainfrom
Conversation
(this PR is easier to review with `&w=1`) Invalid emails are always denied by the code. That means `allow: ["INVALID"]` is equivalent to `allow: []` and the inverse `deny: []` to `deny: ["INVALID"]`. This tests that reality. In the future, this may be changed. But first, tests. Closes GH-3819.
|
😎 Merged successfully - details. |
qw-in
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(this PR is easier to review with
&w=1)Invalid emails are always denied by the code.
That means
allow: ["INVALID"]is equivalent toallow: []and the inversedeny: []meansdeny: ["INVALID"].This tests that reality.
In the future, this may be changed. But first, tests.
Closes GH-3819.