Merged
Conversation
sohkai
reviewed
Aug 25, 2020
| const receipt = await deployed[interface.name]() | ||
| processResult(receipt, false) | ||
| }) | ||
| global[HOOKS_MAP[interface.name]](async () => await deployed[interface.name]()) |
Contributor
There was a problem hiding this comment.
Hmm, double checking here, does this fail properly if one of the hooks throws?
Contributor
Author
There was a problem hiding this comment.
In case some of these reverts, it throws. Note that previously processResult was called with mustAssert set to false always, therefore no assertions were actually being made, we were simply executing calls
Codecov Report
@@ Coverage Diff @@
## next #616 +/- ##
=======================================
Coverage 99.27% 99.27%
=======================================
Files 36 36
Lines 555 555
Branches 74 74
=======================================
Hits 551 551
Misses 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
sohkai
reviewed
Aug 25, 2020
sohkai
approved these changes
Aug 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.