Merged
Conversation
sohkai
approved these changes
Aug 25, 2020
Contributor
sohkai
left a comment
There was a problem hiding this comment.
Looks good, I think we may be able to completely remove the ganache-cli script as a vanilla truffle test and truffle coverage seem to have us covered pretty well? Alternatively we can wait for when we migrate this to buidler (which also shouldn't be very hard I think) to do that.
.solcover.js
Outdated
| 'test', | ||
| 'acl/ACLSyntaxSugar.sol', | ||
| 'common/DepositableStorage.sol', // Used in tests that send ETH | ||
| 'common/UnstructuredStorage.sol' // Used in tests that send ETH |
Contributor
There was a problem hiding this comment.
I think we might be able to remove these from the skipped files now since gas is less of an issue; worth a try?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.