Conversation
Contributor
|
Given that we will be replacing this Very SoonTM with the separated truffle config, I'd rather just make that change and re-release aragonOS then. |
Contributor
Author
|
@sohkai I have updated the PR to use the new truffle v4 package |
sohkai
approved these changes
Oct 22, 2019
Contributor
sohkai
left a comment
There was a problem hiding this comment.
LGTM! Let's follow this up by replacing the deploy logger :).
package.json
Outdated
| "web3-utils": "1.0.0-beta.33" | ||
| }, | ||
| "dependencies": { | ||
| "@aragon/truffle-config-v4": "^1.0.0", |
Contributor
There was a problem hiding this comment.
Let's put this in the devDependencies
|
Congrats on merging your first pull request! Aragon is proud of you 🦅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This
truffleconfig file is still used quite a bit as main configuration and Infura have not been much reliable in some cases reaching the request limits.Long term we should encourage the use of a truffle specific package once we release it.