This repository was archived by the owner on May 22, 2025. It is now read-only.
Merged
Conversation
sohkai
approved these changes
Jul 24, 2020
sohkai
left a comment
There was a problem hiding this comment.
LGTM!
I was debating about moving everything over exactly as it were when we deployed aragonPM last (so on aragonOS v4.0.0), so we could create a tag and deployment log, and then apply the rest of the updates here.
I think this would just involve splitting up this PR into two parts, which may not be so difficult, but if it turns out to be, let's skip it.
test/contracts/ens/ens_subdomains.js
Outdated
| const ens = await ENS.new() | ||
| const newRegProxy = await AppProxyUpgradeable.new(dao.address, hash('apm-enssub.aragonpm.eth'), EMPTY_BYTES) | ||
| const newReg = ENSSubdomainRegistrar.at(newRegProxy.address) | ||
| const newRegProxy = await AppProxyUpgradeable.new(dao.address, hash('apm-enssub.aragonpm.eth'), '0x') |
There was a problem hiding this comment.
Interesting, we may want to play with remix or debug this a bit more.
Theoretically 0x00 should be a bytes array of length 0, but it looks like it may not be interpreted correctly in AppProxyBase.
c04dcf4 to
ef1ba63
Compare
Merged
sohkai
approved these changes
Jul 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recommend reviewing per commit
@sohkai it would be nice to add this repo to Travis