feat: add addWebpackPlugin#91
Merged
Merged
Conversation
FezVrasta
reviewed
May 19, 2019
|
|
||
| ### addWebpackPlugin(plugin) | ||
|
|
||
| Adds the provided plugin info into webpack's plugin array. Pass an plugin defined with `new webpack.DefinePlugin({...})` |
FezVrasta
reviewed
May 19, 2019
| { | ||
| "name": "customize-cra", | ||
| "version": "0.2.12", | ||
| "name": "@zhigang1992/customize-cra", |
Contributor
There was a problem hiding this comment.
Please don't edit the package.json, we'll do that when we release a new version
Contributor
Author
There was a problem hiding this comment.
sry... that wasn't meant to be included.
|
It seems to me that I'll need to install webpack as a dev dependency just to use plugins. Am I correct? If that is the case, CRA throws a long error: |
|
@kumarharsh have you been able to figure out how to add the webpack plugin. no matter what I do it does not append anything into ENV for me and it can't set any global variables. |
|
Sorry, I don't remember much (moved on from the project). I did manage to figure it out, but don't remember the specifics at all :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.