addWorkerLoader#69
Merged
Merged
Conversation
add 'addWorkerLoader'
FezVrasta
reviewed
Mar 13, 2019
| const addWorkerLoader = (loaderOptions = {}) => config => { | ||
| const loaders = config.module.rules.find(rule => Array.isArray(rule.oneOf)).oneOf; | ||
|
|
||
| loaders.splice(loaders.length - 1, 0, { |
Contributor
There was a problem hiding this comment.
What is this splice doing here? Adding to the end of the array the new object?
Contributor
Author
There was a problem hiding this comment.
Keep the same behavior with addLessLoader.
// Insert less-loader as the penultimate item of loaders (before file-loader)
loaders.splice(loaders.length - 1, 0, {
test: lessRegex,
exclude: lessModuleRegex,
Contributor
Author
There was a problem hiding this comment.
I'll give an online example later.
Contributor
There was a problem hiding this comment.
Oh ok I see, thanks for the explanation!
Contributor
Author
There was a problem hiding this comment.
Sorry, I found some error to fix. You are right, the loader shouldn't be added as the penultimate item. This merge should be reverted.
Here is an example:
https://github.com/liyuanqiu/addWorkerLoaderDemo
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.