Skip to content

feat: implement setWebpackTarget#157

Merged
with-heart merged 2 commits into
arackaf:masterfrom
jthistle:webpack-target
Sep 4, 2019
Merged

feat: implement setWebpackTarget#157
with-heart merged 2 commits into
arackaf:masterfrom
jthistle:webpack-target

Conversation

@jthistle

@jthistle jthistle commented Sep 3, 2019

Copy link
Copy Markdown
Contributor

As per: https://webpack.js.org/configuration/target/

This can be useful for things like Electron apps. I've tested this with one of my own apps and it seems to work as expected.

@with-heart

Copy link
Copy Markdown
Collaborator

Hi @jthistle! Thanks for the feature! I've added you to the customize-cra contributors list in our readme :)

@with-heart with-heart merged commit f546a00 into arackaf:master Sep 4, 2019
@jthistle

jthistle commented Sep 4, 2019

Copy link
Copy Markdown
Contributor Author

Thanks for merging this! And for the package as well of course, it's very useful :)

@with-heart

Copy link
Copy Markdown
Collaborator

I'm just the maintainer! This project was built by many people working together, such as yourself! I'll get this published shortly

@with-heart

Copy link
Copy Markdown
Collaborator

It's published under 0.6.0! Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants