chore(pkg): add rollup build process#124
Merged
Merged
Conversation
Collaborator
Author
|
I had a friend (@erikthered) pull these changes down to verify that |
Contributor
|
Why do we need Rollup? Wouldn't a simpler babel compile step be enough? I don't think we need bundles considering this is a node.js package, not meant to run on browser. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #113
This PR enables a build process for the package, allowing us to enable
babeltranspilation, multiple output targets (both cjs and es modules), minification, sourcemaps, and more. This also updates the existing files insrcto useimportandexportsyntax.The majority of the changes live in
package.jsonandrollup.config.js.