test: add coverage for remaining public exports#100
Merged
Conversation
aa119de to
17ba2b4
Compare
Owner
|
@with-heart looks fine to me. I haven't touched this code in ages (I stopped using CRA ages ago). Ping @FezVrasta on any code reviews you want feedback on - or if he's moved on, too, then feel free to just merge. |
Collaborator
Author
|
Gotcha. Good to know! |
Owner
|
If GitHub is set up to require a review, and you can't review it yourself, then let me know and I'll either remove that setting, or just rubber stamp shit for you (probably the former) |
Collaborator
Author
|
Nope, I think everything is set. Haven't run into anything I feel like I'm missing the ability to do yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔬 The one where we test most of the
functionsThis PR adds basic unit tests for most remaining untested non-
babelfunctions. Having test coverage will provide us some safety in doing work, refactoring, fixing docs, etc.This PR does not test
addBundleVisualizerdue to the external deprequire('webpack-bundle-analyzer'), which isn't installed and so cant' be mocked. Not sure how to handle that without adding it as adevDep, which feels so dumb. Any ideas?It also doesn't test
addPostcssPluginsbecause the function has external dependencies and is complex, so I'll follow-up with a PR later refactoring it some to make it more understandable and testable.Completion
require('webpack-bundle-analyzer'))