Merged
Conversation
Closed
Collaborator
christinaflo
left a comment
There was a problem hiding this comment.
I still see references to pae_enabled in docs/source/kernels.md and source/configuration_reference.md, otherwise lgtm
…a model_config setting for now that defaults to true
…l confidence outputs
6a420f3 to
56fafec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since the release of Openfold3 v0.4.0
pae_enabledis always True and we no longer have separate pae enabled / disabled models.Changes
pae_enabledmodel preset and the associated tests. Adds a warning message to warn users that this model preset is deprecated.runner_file_checks.pyRelated Issues
Testing
test_writer.pyandtest_entry_points.pythat previously used thepae_enabledpreset. All other tests have passed.pae_enabledwarning in ModelUpdate validation