deb: fix importing dbgsym packages with versioned Source field #936
Conversation
|
There seem to be some PGP failures due to key expiration/revocation. |
2d86b66 to
021f220
Compare
Codecov Report
@@ Coverage Diff @@
## master #936 +/- ##
==========================================
- Coverage 61.28% 61.26% -0.02%
==========================================
Files 54 54
Lines 5928 5925 -3
==========================================
- Hits 3633 3630 -3
Misses 1770 1770
Partials 525 525
Continue to review full report at Codecov.
|
|
The commit is rebased. PTAL. |
|
ping @lbolla |
|
@peat-psuwit if you rebase this against master I can then merge. |
021f220 to
69c94ce
Compare
|
Please take another look. The test failure seems to be external. |
69c94ce to
0ac0c4f
Compare
0ac0c4f to
23a66b7
Compare
23a66b7 to
11d33ba
Compare
|
@lbolla please take another look. |
|
@neolynx What do you think of this patch? I am not too familiar with this part: I'd appreciate your input before merging. |
lbolla
left a comment
There was a problem hiding this comment.
@peat-psuwit Would you mind rebasing this once more? master now has fully functional unittests run on GH Actions, whose successful run is required for each PR. Thanks!
|
LGTM ! please rebase, if tests are green, we can merge it |
11d33ba to
03702dd
Compare
dpkg-gencontrol can be called with -v flag which set binary package's version separated from source version. When this happen, the Source field will contain version number in addition to source package name. This tripped Aptly's dbgsym restriction, which check for exact source package name, which in turn prevents the dbgsym & the whole .changes file from being imported. From the git history, it seems like this condition is a leftover from when Aptly filter dbgsym packages using "*-dbgsym". So, I decided to remove it. A test case has been added to prevent regression.
03702dd to
efbd387
Compare
|
Rebased and adapt to a change in test utils. Please have another look. |
Requirements
All new code should be covered with tests, documentation should be updated. CI should pass.
Description of the Change
dpkg-gencontrol can be called with -v flag which set binary package's
version separated from source version. When this happen, the Source
field will contain version number in addition to source package name.
This tripped Aptly's dbgsym restriction, which check for exact source
package name, which in turn prevents the dbgsym & the whole .changes
file from being imported.
From the git history, it seems like this condition is a leftover from
when Aptly filter dbgsym packages using "*-dbgsym". So, I decided to
remove it. A test case has been added to prevent regression.
Checklist
AUTHORS