Issues 692 #697
Merged
Issues 692 #697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to https://tools.ietf.org/html/rfc7231#section-4.3.2 HEAD must not have response body so the AWS error code NoSuchKey cannot be received from S3 and we need to fallback to HTTP NotFound error code.
The copy source should be the name of the source bucket and key name of the source object, separated by a slash (/).
Contributor
|
Seems to be related to aws/aws-sdk-go#1213 |
Contributor
Author
|
Yes, it looks like the issue with HEAD response having correctly not any payload impacts the SDK too. I was not able to find any AWS documentation mentioning this behavior. Even worse - it actually mentions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #692