Prefer exact match on package name over provides match #643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When searching for packages which might satisfy given dependency, aptly was first returning packages which `Provides` mentioned name. By default aptly is picking up only first match (unless follow all variants options is enabled), so `Provides:` takes precedence over exact package name match. Invert this logic by searching first for package name match.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When searching for packages which might satisfy given dependency,
aptly was first returning packages which
Providesmentionedname. By default aptly is picking up only first match (unless
follow all variants options is enabled), so
Provides:takesprecedence over exact package name match.
Invert this logic by searching first for package name match.
Fixes #618
Checklist
AUTHORS