Skip to content

Fix S3 path caching double-prefix #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
smira merged 1 commit into from
Aug 16, 2017
Merged

Fix S3 path caching double-prefix #622

smira merged 1 commit into from
Aug 16, 2017

Conversation

@smira
Copy link
Contributor

@smira smira commented Aug 16, 2017

Original PR: #621
Fixes: #619

I've added unit-test to Martyn's PR.

Description

Without this fix, if prefix is set on S3 publish endpoint,
aptly would incorrectly build path cache and re-upload every object
on publish.

Checklist

  • unit-test added (if change is algorithm)
  • functional test added/updated (if change is functional)
  • man page updated (if applicable)
  • bash completion updated (if applicable)
  • documentation updated
  • author name in AUTHORS

@smira
Fix S3 path caching double-prefix
790d858 
Original PR: #621
Fixes: #619

I've added unit-test to Martyn's PR.

Without this fix, if `prefix` is set on S3 publish endpoint,
aptly would incorrectly build path cache and re-upload every object
on publish.
@smira smira added the 1.2.0 label Aug 16, 2017
@smira smira merged commit cbc8051 into master Aug 16, 2017
@smira smira mentioned this pull request Aug 16, 2017
Closed
@smira smira deleted the 619-s3-prefix branch September 28, 2017 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

S3 publishing endpoint appears to reupload everything

2 participants

@smira