Skip to content

Conversation

@sliverc
Copy link
Contributor

@sliverc sliverc commented May 23, 2017

As a follow up on PR https://github.com/smira/aptly/pull/363 this PR fixes #184.

Description of the Change

The discussion in #363 resulted in that additional fields in Release file are fairly specific and are mainly handled by aptly itself exception being NotAutomatic, ButAutomaticUpgrades and Origin fields. What would be desirable though is to inherit those fields from mirror directly.

So what I implemented in this PR is:

  • automatically inheriting Origin, NotAutomatic and ButAutomaticUpgrades fields from mirror, in case all snapshots which are being published have the same value of this field.
  • if a publishes consist of several snapshots with different values of those fields, in case of NotAutomatic and ButAutomaticUpgrades those won't be added (same behaviour as today) and Origin will be generated with prefix and distribution (same behaviour as today)
  • those 3 flags can always be overwritten during publish with command line flags -origin, -notautomatic, -butautomaticupgrades

Checklist

  • unit-test added (if change is algorithm)
  • functional test added/updated (if change is functional)
  • man page updated (if applicable)
  • bash completion updated (if applicable)
  • documentation updated
  • author name in AUTHORS

@sliverc
Copy link
Contributor Author

sliverc commented May 23, 2017

Update for documentation: aptly-dev/www.aptly.info#44

dl.bintray.com seems to be a bit flaky today hence some tests failed. I guess best to rerun again at a later point.

@sliverc sliverc force-pushed the backport_support branch from 32702f8 to e3f1880 Compare July 5, 2017 13:08
Copy link
Contributor

@smira smira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@smira smira merged commit 20b874f into aptly-dev:master Jul 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reuse all field from a mirror Release file in the generated release

2 participants