Add mirror api #573
Closed
Add mirror api #573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 22, 2017
0850206 to
da5ee55
Compare
1f97205 to
44b9607
Compare
47980ad to
97bc3ae
Compare
9245db9 to
5913126
Compare
ce564f0 to
d6c51df
Compare
a6da49b to
d361938
Compare
d361938 to
3586879
Compare
Closed
ead5a6b to
07622a2
Compare
Codecov Report
@@ Coverage Diff @@
## master #573 +/- ##
=========================================
+ Coverage 60.64% 60.94% +0.3%
=========================================
Files 50 54 +4
Lines 6276 6422 +146
=========================================
+ Hits 3806 3914 +108
- Misses 2033 2081 +48
+ Partials 437 427 -10
Continue to review full report at Codecov.
|
added 9 commits
July 6, 2018 15:06
this is needed so concurrent reads and writes are possible.
This way db usage is safe.
Progress is not safe so for api its always nil and code needs to take care of this
|
What is the status of this PR? It has been open for a very long time.. Would love to have the mirror functionality exposed over API. |
Contributor
Author
|
@pleemann #459 would need to land first. Issue there is that it has to be adjusted to be backwards compatible. See #459 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces an async mirror api based on work made in #166 it additionally provides GPG end point to add additional keys. Otherwise won't it be possible to update new mirrors only through the API without using command line.
This mirror api is based on the concept of the task api introduced in PR #459. Hence, #459 needs to be agreed upon and merged first, before this PR can be processed.
For now to easier verify changes have a look directly at commits sliverc@100edad and sliverc@611824e
As this is a lengthy PR once its core concept is agreed upon I will be happy to update the documentation as well.
Checklist
AUTHORS