Skip to content

Conversation

@boxjan
Copy link
Contributor

@boxjan boxjan commented May 6, 2025

Fixes #

Requirements

All new code should be covered with tests, documentation should be updated. CI should pass.

Description of the Change

This patch enhances the Aptly bash‐completion script by collecting and
reusing any global options passed to aptly so that completions work
correctly when users supply flags such as --config, --architectures,
--gpg-provider, etc.

Key changes:

  • Introduce aptly_global_opts array to accumulate recognized global options.
  • Implement path‐completion (_filedir) for options in options_with_path_arg.
  • Fix typo where compopt was misspelled as comptopt.

Checklist

  • unit-test added (if change is algorithm)
  • functional test added/updated (if change is functional)
  • man page updated (if applicable)
  • bash completion updated (if applicable)
  • documentation updated
  • author name in AUTHORS

@neolynx neolynx self-assigned this May 25, 2025
@neolynx neolynx self-requested a review May 25, 2025 20:52
Copy link
Member

@neolynx neolynx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot !

@neolynx neolynx merged commit a11e004 into aptly-dev:master May 25, 2025
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants