Skip to content

go: use version 1.24 #1439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
neolynx merged 4 commits into from
May 1, 2025
Merged

go: use version 1.24 #1439

neolynx merged 4 commits into from
May 1, 2025

Conversation

@neolynx
Copy link
Member

@neolynx neolynx commented Apr 12, 2025 •
edited
Loading

Fixes #1438

Description of the Change

use go version 1.24

  • development env: base on debian trixie with go1.24
  • lint: run with default config
  • fix lint errors
  • fix unit tests
  • fix system test

@neolynx neolynx self-assigned this Apr 12, 2025
@neolynx neolynx force-pushed the feature/go-1.24 branch 2 times, most recently from f10bf60 to ab961fb Compare April 12, 2025 20:05
@codecov
Copy link

codecov bot commented Apr 12, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.19328% with 60 lines in your changes missing coverage. Please review.

Project coverage is 75.02%. Comparing base (c05068c) to head (9a21717).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
context/context.go 23.07% 9 Missing and 1 partial ⚠️
deb/graph.go 36.36% 5 Missing and 2 partials ⚠️
api/publish.go 0.00% 4 Missing ⚠️
deb/index_files.go 42.85% 4 Missing ⚠️
files/public.go 60.00% 4 Missing ⚠️
cmd/db_cleanup.go 57.14% 3 Missing ⚠️
files/package_pool.go 50.00% 3 Missing ⚠️
swift/public.go 66.66% 3 Missing ⚠️
task/list.go 40.00% 3 Missing ⚠️
api/api.go 90.47% 2 Missing ⚠️
... and 11 more
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1439   +/-   ##
=======================================
  Coverage   75.02%   75.02%           
=======================================
  Files         157      157           
  Lines       18362    18385   +23     
=======================================
+ Hits        13776    13794   +18     
- Misses       3446     3451    +5     
  Partials     1140     1140

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@neolynx neolynx force-pushed the feature/go-1.24 branch 2 times, most recently from 987c727 to 3a31407 Compare April 26, 2025 10:43
neolynx added 2 commits April 26, 2025 13:29
@neolynx
go1.24: fix lint, unit and system tests
f7057a9 
- development env: base on debian trixie with go1.24
- lint: run with default config
- fix lint errors
- fix unit tests
- fix system test
@neolynx
Makefile: allow no cache docker build
c67cafc
@neolynx neolynx requested a review from a team April 26, 2025 11:32
@neolynx neolynx added needs review Ready for review & merge needs approval labels Apr 26, 2025
@neolynx neolynx merged commit 2cafbc8 into master May 1, 2025
47 checks passed
@neolynx neolynx deleted the feature/go-1.24 branch May 1, 2025 08:14
@neolynx neolynx mentioned this pull request May 1, 2025
Closed
@BrewTestBot BrewTestBot mentioned this pull request Jun 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@szakalboss szakalboss szakalboss approved these changes

Assignees

@neolynx neolynx

Labels

needs approval needs review Ready for review & merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

invalid go version '1.22.7': must match format 1.23

3 participants

@neolynx @szakalboss