Skip to content

Give info when unable to load list of repos #1064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
randombenj merged 1 commit into from
Apr 25, 2022
Merged

Give info when unable to load list of repos #1064

randombenj merged 1 commit into from
Apr 25, 2022

Conversation

@smutel
Copy link
Contributor

@smutel smutel commented Apr 22, 2022

This PR is a workaround for #428.

Requirements

All new code should be covered with tests, documentation should be updated. CI should pass.

Description of the Change

The idea is to have information about publish which is in trouble and to be able to drop it and to re-publish it.

Checklist

  • unit-test added (if change is algorithm)
  • functional test added/updated (if change is functional)
  • man page updated (if applicable)
  • bash completion updated (if applicable)
  • documentation updated
  • author name in AUTHORS

@randombenj randombenj self-requested a review April 25, 2022 08:11
@randombenj
Copy link
Contributor

randombenj commented Apr 25, 2022

Thanks for the change. I would suggest to print those messages to stderr as, especially when printing json, this might break existing scripts trying to parse the output. What do you think @smutel ?

@smutel
Copy link
Contributor Author

smutel commented Apr 25, 2022

Sure. I updated my PR.

randombenj
randombenj approved these changes Apr 25, 2022
View reviewed changes
Copy link
Contributor

@randombenj randombenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@randombenj randombenj merged commit 4c04e77 into aptly-dev:master Apr 25, 2022
@randombenj randombenj added this to the 1.5.0 milestone Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@randombenj randombenj randombenj approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.5.0

Development

Successfully merging this pull request may close these issues.

2 participants

@smutel @randombenj