Skip to content

Issue/revive unittests #1024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lbolla merged 3 commits into from
Feb 8, 2022
Merged

Issue/revive unittests #1024

lbolla merged 3 commits into from
Feb 8, 2022

Conversation

@lbolla
Copy link
Contributor

@lbolla lbolla commented Feb 8, 2022

Description of the Change

Many tests were disabled during the migration from TravisCI to GH Actions. This patchset renables most of them.

@lbolla lbolla requested review from neolynx and randombenj February 8, 2022 07:49
@lbolla lbolla self-assigned this Feb 8, 2022
@lbolla
Copy link
Contributor Author

lbolla commented Feb 8, 2022 •
edited
Loading

Now the test suite is up to:

TESTS: 510 SUCCESS: 510 FAIL: 0 SKIP: 16

from

TESTS: 490 SUCCESS: 490 FAIL: 0 SKIP: 36

The 16 still skipped tests are:

      5:SKIP: public_test.go:360: PublishedStorageSuite.TestFileExists
      6:SKIP: public_test.go:149: PublishedStorageSuite.TestFilelist
      7:SKIP: public_test.go:172: PublishedStorageSuite.TestFilelistPlus
      8:SKIP: public_test.go:273: PublishedStorageSuite.TestLinkFromPool
      9:SKIP: public_test.go:115: PublishedStorageSuite.TestPutFile
     10:SKIP: public_test.go:134: PublishedStorageSuite.TestPutFilePlus
     11:SKIP: public_test.go:195: PublishedStorageSuite.TestRemove
     12:SKIP: public_test.go:227: PublishedStorageSuite.TestRemoveDirs
     13:SKIP: public_test.go:241: PublishedStorageSuite.TestRemoveDirsPlus
     14:SKIP: public_test.go:211: PublishedStorageSuite.TestRemovePlus
     15:SKIP: public_test.go:255: PublishedStorageSuite.TestRenameFile
     16:SKIP: public_test.go:346: PublishedStorageSuite.TestSymLink
    476:SKIP: <autogenerated>:1: Gnupg2SignerSuite.TestClearSignNoPassphraseDefaultKey (test for default key skipped)
    481:SKIP: <autogenerated>:1: Gnupg2SignerSuite.TestClearSignPassphraseDefaultKey (test for default key skipped)
    490:SKIP: <autogenerated>:1: Gnupg2SignerSuite.TestSignDetachedNoPassphraseDefaultKey (test for default key skipped)
    495:SKIP: <autogenerated>:1: Gnupg2SignerSuite.TestSignDetachedPassphraseDefaultKey (test for default key skipped)

The first are for the Azure storage, for which we have no keys.
The other are autogenerated gnupg tests.

randombenj
randombenj approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@randombenj randombenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lbolla lbolla merged commit e8ec638 into master Feb 8, 2022
@lbolla lbolla deleted the issue/revive-unittests branch February 8, 2022 10:19
@randombenj randombenj mentioned this pull request Mar 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@neolynx neolynx Awaiting requested review from neolynx

1 more reviewer

@randombenj randombenj randombenj approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lbolla lbolla

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lbolla @randombenj