Skip to content

fix(realtime): memory leak #2 #1627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TorstenDittmann merged 4 commits into from
Sep 15, 2021
Merged

fix(realtime): memory leak #2 #1627

TorstenDittmann merged 4 commits into from
Sep 15, 2021

Conversation

@TorstenDittmann
Copy link
Contributor

@TorstenDittmann TorstenDittmann commented Sep 15, 2021

What does this PR do?

  • fixes memory leak that got caused when getting PDO connections from the pool, but not returning due to an early return

Have you read the Contributing Guidelines on issues?

✅

@TorstenDittmann TorstenDittmann changed the base branch from master to 0.10.x September 15, 2021 14:02
@TorstenDittmann TorstenDittmann merged commit 1fbb37b into appwrite:0.10.x Sep 15, 2021
@TorstenDittmann TorstenDittmann deleted the fix-realtime-memory-leak-2 branch September 15, 2021 14:03
@ElectronSz
Copy link

ElectronSz commented Sep 27, 2021

I love you guys. This is good! How do we donate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@kodumbeats kodumbeats kodumbeats approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TorstenDittmann @ElectronSz @kodumbeats