tests/e2e/Client.php (1)

111-123: Trim and ignore empty values to harden the API.

Guard against accidental whitespace or empty strings so callers don’t have to.

Apply this diff:

 public function setResponseFormat(string $value): self
 {
-    $this->addHeader('X-Appwrite-Response-Format', $value);
+    $value = trim($value);
+    if ($value === '') {
+        return $this;
+    }
+    $this->addHeader('X-Appwrite-Response-Format', $value);
 
     return $this;
 }

tests/e2e/Scopes/Scope.php (1)

28-31: Avoid PHP’s empty('0') pitfall; trim input.

Using empty() can skip valid “0”-like values. Prefer strict check against empty string after trim.

Apply this diff:

-        $format = System::getEnv('_APP_E2E_RESPONSE_FORMAT');
-        if (!empty($format)) {
+        $format = trim((string) System::getEnv('_APP_E2E_RESPONSE_FORMAT'));
+        if ($format !== '') {
             $this->client->setResponseFormat($format);
         }

.github/workflows/tests.yml (2)

111-114: Use non-interactive exec (-T) for CI consistency.

Most other execs use -T; align unit tests to avoid tty allocation quirks.

Apply this diff:

-          docker compose exec \
+          docker compose exec -T \
             -e _APP_E2E_RESPONSE_FORMAT="${{ github.event.inputs.response_format }}" \
             appwrite test /usr/src/code/tests/unit

---

521-521: Add trailing newline at EOF.

Fix YAMLlint “no new line at end of file”.

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

tests/e2e/Scopes/Scope.php (1)

28-28: Add discoverability for the new env var.
Please add _APP_E2E_RESPONSE_FORMAT to the .env example and docs.

tests/e2e/Scopes/Scope.php (1)

28-37: Harden env parsing and error messaging.
Trim the value, avoid empty() edge cases, and surface the invalid value with a more specific exception type.

-        $format = System::getEnv('_APP_E2E_RESPONSE_FORMAT');
-        if (!empty($format)) {
+        $format = \trim((string) System::getEnv('_APP_E2E_RESPONSE_FORMAT'));
+        if ($format !== '') {
             if (
                 !\preg_match('/^\d+\.\d+\.\d+$/', $format) ||
                 !\version_compare($format, APP_VERSION_STABLE, '<=')
             ) {
-                throw new \Exception('E2E response format must be ' . APP_VERSION_STABLE . ' or lower.');
+                throw new \InvalidArgumentException(
+                    "Invalid E2E response format '{$format}'. Must be <= " . APP_VERSION_STABLE . '.'
+                );
             }
             $this->client->setResponseFormat($format);
         }

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.