Skip to content

Skaffold config will preserve Sync sections if defined#708

Merged
marcinc merged 1 commit intomasterfrom
fix-skaffold-file
Nov 16, 2022
Merged

Skaffold config will preserve Sync sections if defined#708
marcinc merged 1 commit intomasterfrom
fix-skaffold-file

Conversation

@marcinc
Copy link
Member

@marcinc marcinc commented Nov 15, 2022

Any file syncing rules that may have been manually added to the skaffold.yaml manifest will now be preserved for each respective build artefact. Previously render and dev subcommands would strip sync block entirely.

Example:

apiVersion: skaffold/v2beta14
kind: Config
metadata:
  name: App
build:
  artifacts:
    - image: myregistry.example.com/org/repo
      context: app
      sync:    # <---- manually added file syncing block will now be preserved with `kev render` / `kev dev` commands.
        manual:
          - src: src/**/*
            dest: /app
  tagPolicy:
    gitCommit:
      variant: Tags
  local: {}

@marcinc marcinc requested a review from KashifSaadat November 15, 2022 19:43
Copy link
Member

@KashifSaadat KashifSaadat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcinc marcinc merged commit 71fd5d1 into master Nov 16, 2022
@marcinc marcinc deleted the fix-skaffold-file branch November 16, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants