Skip to content

Add ability to specify prefix for exposed service hostname#701

Merged
marcinc merged 5 commits intomasterfrom
expose-prefix
Nov 9, 2022
Merged

Add ability to specify prefix for exposed service hostname#701
marcinc merged 5 commits intomasterfrom
expose-prefix

Conversation

@marcinc
Copy link
Member

@marcinc marcinc commented Nov 8, 2022 •
edited
Loading

This PR adds the ability to specify hostname prefix for the exposed service.

When specified it'll be prepended to the domain name.

Example:

For prefix hello. and domain name world.example.com it'll result in ingress hostname set as hello.world.example.com.

Example config:

version: 3.7
services:
  my-service:
    x-k8s:
      service:
        expose:
          domainPrefix: hello.
          domain: world.example.com
...

@marcinc marcinc requested a review from KashifSaadat November 8, 2022 17:50
@marcinc marcinc force-pushed the expose-prefix branch 2 times, most recently from bdf2025 to b0dca03 Compare November 8, 2022 21:42
KashifSaadat
KashifSaadat reviewed Nov 9, 2022
View reviewed changes
KashifSaadat
KashifSaadat previously approved these changes Nov 9, 2022
View reviewed changes
Copy link
Member

@KashifSaadat KashifSaadat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@marcinc marcinc requested a review from KashifSaadat November 9, 2022 09:39
@marcinc marcinc merged commit bd746af into master Nov 9, 2022
@marcinc marcinc deleted the expose-prefix branch November 9, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KashifSaadat KashifSaadat KashifSaadat approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marcinc @KashifSaadat