Skip to content

Rename application-generated filenames#588

Merged
chriswalker merged 10 commits intomasterfrom
584-file-renaming
Jun 25, 2021
Merged

Rename application-generated filenames#588
chriswalker merged 10 commits intomasterfrom
584-file-renaming

Conversation

@chriswalker
Copy link
Contributor

Addresses #584.

Modifies generation of environment override filenames by providing a dedicated infix constant (rather than deriving the infix portion of the generated docker-compose filenames from the app manifest name, which is now going to deviate anyway). Specifically, now generates docker-compose.env.[environment].yaml instead of docker-compose.kev.[environment].yaml.

Also involves changes to:

  • All tests and fixtures to use new naming conventions,
  • The Wordpress example files,
  • The tutorial files to reflect new filename changes,
  • The e2e help Bash script.

Raised as a draft initially as further work is incoming around renaming of kev.yaml to... something else, which will also be handled as part of this PR.

Copy link
Member

@marcinc marcinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny comment, otherwise LGTM 👍

Copy link
Contributor

@ezodude ezodude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@chriswalker chriswalker marked this pull request as ready for review June 24, 2021 10:23
Copy link
Member

@marcinc marcinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of tiny comments. Otherwise it’s good to go! 👍

Copy link
Member

@marcinc marcinc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants