Rename application-generated filenames#588
Merged
chriswalker merged 10 commits intomasterfrom Jun 25, 2021
Merged
Conversation
marcinc
reviewed
Jun 24, 2021
Member
marcinc
left a comment
There was a problem hiding this comment.
One tiny comment, otherwise LGTM 👍
marcinc
reviewed
Jun 24, 2021
Member
marcinc
left a comment
There was a problem hiding this comment.
Couple of tiny comments. Otherwise it’s good to go! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #584.
Modifies generation of environment override filenames by providing a dedicated infix constant (rather than deriving the infix portion of the generated
docker-composefilenames from the app manifest name, which is now going to deviate anyway). Specifically, now generatesdocker-compose.env.[environment].yamlinstead ofdocker-compose.kev.[environment].yaml.Also involves changes to:
Raised as a draft initially as further work is incoming around renaming of
kev.yamlto... something else, which will also be handled as part of this PR.